[Acados v0.5.5][1/5] Upgrade compatibility baseline - #1087
Closed
mickaelbegon wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing this draft to reduce the active PR load. The work remains available on |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
+ Coverage 77.26% 77.87% +0.61%
==========================================
Files 196 196
Lines 21506 21514 +8
==========================================
+ Hits 16616 16755 +139
+ Misses 4890 4759 -131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This draft PR is the first implementation step from a Codex analysis of the
Acados v0.5.5 release and its relevant additions for Bioptim.
It upgrades the bundled Acados submodule from v0.5.1 to v0.5.5 and establishes
the compatibility baseline required by the follow-up PRs. It is intentionally
kept as WIP for maintainer review.
Changes
external/acadosto the official v0.5.5 tag;AcadosOcp.code_gen_options;c_compile=Falsebehavior by disabling Acados'automatic reuse override for now;
@rpathhandling for the installed libraries;Validation
origin/masteris unchanged since the branch point (e8fbc729);DYLD_LIBRARY_PATH;bash -n external/acados_install_linux.sh external/acados_install_mac.sh;tests/shard1/test_acados_interface.py: 29 passed.Planned follow-ups
codex/acados-v055-reuse-reset— generated-code reuse and solver resetcodex/acados-v055-solver-modes— relevant new solver modes/optionscodex/acados-v055-diagnostics— richer status and diagnostic reportingcodex/acados-v055-runtime-parameters— runtime parameter update pathsThe later branches are placeholders based on
master; each will be rebased onthe preceding accepted dependency when its implementation starts.
Note for maintainers
This proposal and the five-PR decomposition come from a Codex compatibility and
feature analysis. Maintainer feedback is especially welcome on the scope and
ordering before the follow-up implementations are finalized.
This change is